BACKENDS: Fix screen rotation#6699
Merged
lephilousophe merged 5 commits intoscummvm:masterfrom Jun 15, 2025
Merged
Conversation
lephilousophe
force-pushed
the
fix-rotation
branch
from
bcc6045 to
791661e
Compare
lephilousophe
force-pushed
the
fix-rotation
branch
2 times, most recently
from
3e8f351 to
bbd3b81
Compare
Also make flip parameter separate from size.
The rotation is fully handled by the WindowedGraphicsManager including for the mouse mapping. The draw rect is always in window coordinates.
This has only worked correctly in some specific cases (screen centered, no shaders, ...).
This also avoids configuration lookups at every frame update.
lephilousophe
force-pushed
the
fix-rotation
branch
from
bbd3b81 to
475c783
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The screen rotation feature only worked in specific cases and is now fixed to handle all of them.
The only thing not handled is OpenGL platforms without FBO but nothing simple can be done for that.
Also makes it behaves like other settings with a dedicated setter invoked during GFX transactions.
Although OpenGL graphics manager and WindowedGraphicsManager handle the rotation, let the platform specific backend decide if the mode should be supported.
The main change in the PR is that the drawing rectangles managed by WindowedGraphicsManager are now always in window coordinates in every case and the other graphic manager handle rotation around it.