VIDEO: QTVR: Fix hard coded maximum zoom value#6694
Merged
sev- merged 1 commit intoscummvm:masterfrom Jun 6, 2025
Merged
Conversation
Instead of hard coded value of 65 degrees (determined using experimentation) calculate the maximum value using the panorama top and bottom bounds. This way the FOV won't go out of bounds for any director movie/
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading the Panorama sample description, if the maximum zoom
and minimum zoom values are not present, ScummVM Director assigns
hard coded values of 65 degrees (for maximum zoom) and 5 degrees
(for minimum zoom). However, for panorama movies smaller tilting range,
that may get out of bounds. So, instead we should decide maximum zoom
based on its vertical panning range.