MADE: Split up the music player class to support other platforms#6681
Merged
bluegr merged 1 commit intoscummvm:masterfrom Jun 9, 2025
Merged
MADE: Split up the music player class to support other platforms#6681bluegr merged 1 commit intoscummvm:masterfrom
bluegr merged 1 commit intoscummvm:masterfrom
Conversation
Member
|
Is the Mac version music format supported by the Halestorm driver? I was under the impression that all versions use the same music format |
Member
Author
|
There's some discussion on the subject on Discord: https://discord.com/channels/581224060529148060/711242520415174666/1379133782518665279 |
Member
|
The Mac version doesn't even start at the moment. It seems to have either endianess issues, or differences in opcodes. This is a step towards the right direction, so once we manage to get the Mac version working, we can check for the music format and music playing. Thanks! Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Macintosh music hasn't been implemented yet, but it should be relatively simple to reuse the Halestorm driver from the Kyra engine.