Merged
Conversation
lephilousophe
force-pushed
the
rtl-cleanup
branch
from
0c82a51 to
8c92c8e
Compare
The hack was here because the RTL aware code was incomplete. Fix everything and remove useless code.
lephilousophe
force-pushed
the
rtl-cleanup
branch
from
8c92c8e to
b3f087a
Compare
Member
|
Good stuff. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hack was here because the RTL aware code was incomplete.
Fix everything and remove useless code.
I still see a small bug, in the launcher in list grouped view, the collapsing arrows are not drawn except when rendering the option dialog. In which case, they are misplaced like if they were not RTL.
I hope to have time to fix it soon.
Tested with the guiRTL option set to true.