JANITORIAL: Fix MSVC macro redefinition warnings#6663
Merged
lephilousophe merged 5 commits intoscummvm:masterfrom May 30, 2025
Merged
JANITORIAL: Fix MSVC macro redefinition warnings#6663lephilousophe merged 5 commits intoscummvm:masterfrom
lephilousophe merged 5 commits intoscummvm:masterfrom
Conversation
Our includes must come before flex generated code to avoid macro redefinition of INTx_MIN/MAX macros. Also make the license appear at the top of the generated file.
Our includes must come before flex generated code to avoid macro redefinition of INTx_MIN/MAX macros. Also make the license appear at the top of the generated file.
Our includes must come before flex generated code to avoid macro redefinition of INTx_MIN/MAX macros. Also make the license appear at the top of the generated file.
It triggers on libvpx because MSVC doesn't provide any way to acknowledge a static function is unused.
Member
Author
|
Also disable C4505 warning as it triggers a lot on libvpx while we can't do anything about it. |
lephilousophe
force-pushed
the
fix-msvc-redef
branch
from
4529c37 to
4244017
Compare
Member
Author
|
Also fixing unused variable warnings in HPL1. |
This fixes MSVC C4189 warnings about unreferenced local variables.
lephilousophe
force-pushed
the
fix-msvc-redef
branch
from
4244017 to
cad57ab
Compare
Member
Author
|
Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our includes must come before flex generated code to avoid macro redefinition of INTx_MIN/MAX macros.
Also make the license appear at the top of the generated file.
This PR is mostly to check MSVC result.