Looks good, thanks!

Ugh. This wasn't tested at all - it crashes on startup. Will provide a proper fix.

Regression fixed in 80c635b

Ugh. This wasn't tested at all - it crashes on startup. Will provide a proper fix.

Just for the record - It was tested (and works) on release. The crash is a failed assertion, which only happens on debug build.

Ugh. This wasn't tested at all - it crashes on startup. Will provide a proper fix.

Just for the record - It was tested (and works) on release. The crash is a failed assertion, which only happens on debug build.

That assertion was triggered because SCI version isn't initialized before the engine starts. It's a fundamental issue. The fact that the assert isn't thrown in release builds doesn't mean much :)
The assert was thrown on ScummVM startup, so it was pretty obvious to spot

I understand, but for release build assert is no-op. Quoting the man page:

If the macro NDEBUG is defined at the moment <assert.h> was last included, the macro assert() generates no code, and hence does nothing at all. It is not recommended to define NDEBUG if using assert() to detect error conditions since the software may behave non-deterministically.

I understand, but for release build assert is no-op. Quoting the man page:

That is not correct. assert is a no-op if NDEBUG is defined. But we do not define NDEBUG for release builds (except for a few exceptions such as the Atari port where the added performance of making it a no-op is noticeable). Defining NDEBUG for release builds was proposed and discussed in PR #2486, and was not merged in the end.

I understand, but for release build assert is no-op. Quoting the man page:

That is not correct. assert is a no-op if NDEBUG is defined. But we do not define NDEBUG for release builds (except for a few exceptions such as the Atari port where the added performance of making it a no-op is noticeable). Defining NDEBUG for release builds was proposed and discussed in PR #2486, and was not merged in the end.

It is correct for cmake apparently. I'll try to remove the flag.