GRIM: Fix failed assertion on font rendering with TinyGL#6631
Merged
orgads merged 1 commit intoscummvm:masterfrom May 18, 2025
Merged
GRIM: Fix failed assertion on font rendering with TinyGL#6631orgads merged 1 commit intoscummvm:masterfrom
orgads merged 1 commit intoscummvm:masterfrom
Conversation
Opening the menu (F1) in a debug build triggers a crash due to an assertion failure in surface.h: assert(x >= 0 && x < w && y >= 0 && y < h). This problem occurs because setPixel is called with x equal to w. It's especially noticeable when rendering a single "Q" character, where the kerned width is 12, but the bitmap width is 14 pixels. getBitmapStringLength returns the sum of character advance widths Kerning applies to spacing between glyphs not bitmap widths. Since no subsequent glyph follows the final character, kerning is unused. Therefore the final character's bitmap width must be used This prevents setPixel from receiving x coordinates equal to w.
aquadran
approved these changes
May 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening the menu (F1) in a debug build triggers a crash due to an assertion failure in surface.h:
This problem occurs because
setPixelis called with x equal to w. It's especially noticeable when rendering a single "Q" character, where the kerned width is 12, but the bitmap width is 14 pixels.getBitmapStringLengthreturns the sum of character advance widths Kerning applies to spacing between glyphs not bitmap widths.Since no subsequent glyph follows the final character, kerning is unused. Therefore the final character's bitmap width must be used This prevents
setPixelfrom receiving x coordinates equal to w.