GRIM: Suppress compiler warning on release build#6617
Merged
orgads merged 1 commit intoscummvm:masterfrom May 14, 2025
Merged
Conversation
Contributor
orgads
commented
May 14, 2025
orgads
commented
Member
|
I think it's not original intention to change this way. I think it will break engine. |
aquadran
requested changes
May 14, 2025
Member
aquadran
left a comment
aquadran
left a comment
There was a problem hiding this comment.
this can not be changed like that
In function 'void Grim::addnchar(const char*, int32)',
inlined from 'void Grim::addstr(const char*)' at engines/grim/lua/lstrlib.cpp:25:10,
inlined from 'void Grim::str_rep()' at engines/grim/lua/lstrlib.cpp:75:9:
engines/grim/lua/lstrlib.cpp:20:16: warning: 'char* strncpy(char*, const char*, size_t)' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
20 | strncpy(b, s, n);
| ~~~~~~~^~~~~~~~~
In function 'void Grim::addstr(const char*)',
inlined from 'void Grim::str_rep()' at engines/grim/lua/lstrlib.cpp:75:9:
engines/grim/lua/lstrlib.cpp:25:27: note: length computed here
25 | addnchar(s, strlen(s));
| ~~~~~~^~~
Contributor
Author
|
Ok, suppressed the warning instead. |
aquadran
approved these changes
May 14, 2025
orgads
changed the title
Contributor
Author
|
@aquadran Can we replace |
Member
|
I think it's the best way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.