Please fix code formatting

Sorry missed the formatting issues. Fixed now (and I also fixed some older formatting issues in the same files)

Support opening logfile in Emscripten: This is similar to the screenshot export from #5587. I added a button to download the log file:

Would it be possible to have this button in desktop builds too, which would open the log file with the default system text editor?

I havent seen any comparable function to open files on the host system in OSystem or any specific backend. The reason I added this to Emscripten was because theres no good way to access the filesystem (intially needed for screenshots), but in theory this could work everywhere if we feel its worth implementing for each backend. Probably should be added as an optional feature to OSystem.

PS: I wonder how the mobile platforms solve this, its not that easy to access the filesystem there either.

I havent seen any comparable function to open files on the host system in OSystem or any specific backend. The reason I added this to Emscripten was because theres no good way to access the filesystem (intially needed for screenshots), but in theory this could work everywhere if we feel its worth implementing for each backend. Probably should be added as an optional feature to OSystem.

PS: I wonder how the mobile platforms solve this, its not that easy to access the filesystem there either.

We do have displayLogFile(), a function called to open our default log file in the system's default text editor.

This function is implemented in some of our backends (including Emscripten).

Perhaps we could override the log file name that is opened by this function?

I added a feature to this effect. There's now also displayFile which let's you open any arbitrary file. I did not want to limit myself to log files, as in Emscripten I already need something to open screenshots and I imagine other platforms also having a use for that.

edit: I'll fix the typos breaking CI later today

@bluegr after the discussion on discord I removed cfda843. I think for now it's probably easier to keep this button limited to Emscripten and later add functionality to open such files on any platform properly:

if this “open file” is to be generalized, it should actually also be implemented in other backends (e.g. share sheet in iOS/Android) and use cases (screenshots maybe). theres no point generalizing in advance.
unless its the default logfile or a screenshot, “desktop backends” (macOS, Linux, Windows) with access to the whole system FS (no app isolation) should open the containing folder, not launch any arbitrary file.

@chkuendig We discussed about implementing the log file reading functionality in the UI, instead of making it backend-specific.

We do display the main logfile in the options GUI. It would be preferable to use a single implementation this way, instead of something that's only available to a single backend

@bluegr I adjusted it accordingly.

@chkuendig Excellent work! Thanks for addressing all issues

Squashing