Merged
Conversation
bluegr
reviewed
May 18, 2025
gui/cloudconnectionwizard.h
Outdated
| CloudConnectionWizard(); | ||
| ~CloudConnectionWizard() override; | ||
|
|
||
| int runModal(uint32 selectedStorageIndex); |
Member
There was a problem hiding this comment.
This uses the same name as a member function in the base class, but it does not override it, which is why you added that using statement above.
It would be preferable to give this method a different name instead, e.g. runStorageModal(), to avoid unnecessary name clashes
Member
|
Nice work, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the cloud wizard a bit:
kOpenUrlStorageCmdbut still left it inoptions.cpp.kCloudConnectionWizardOpenUrlStorageCmdingui/cloudconnectionwizard.cppbut doesn't consider the selected storage option anymore to construct the URL (despite selecting one still being required inoptions.cpp). This PR now passes the selected storage again to the opened URL as it was before.UI Flow can also be observed at https://youtu.be/kYechxc5tvE as discussed at https://discord.com/channels/581224060529148060/581224061091446795/1370153256176713808