TWP: FREESCAPE: Fix non-compliant GLSL#6602
Merged
chkuendig merged 2 commits intoscummvm:masterfrom May 9, 2025
Merged
Conversation
chkuendig
changed the title
bluegr
reviewed
May 8, 2025
bluegr
reviewed
May 8, 2025
bluegr
reviewed
May 8, 2025
bluegr
reviewed
May 8, 2025
…ot be compared with non-constant expression.
Contributor
|
I just tested freescape using the new shaders and looks good. I think we need @scemino to take a look to the TWP changes and we are ready to go. |
neuromancer
approved these changes
May 9, 2025
Contributor
|
I read your commits, it seems good to me, but I didn't test it. |
scemino
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenGLES 2.0 GLSL requires:
Generally this doesn't seem to be a limit enforced on most hardware, but for WebGL, this conformity seems to be enforced by the ANGLE Compiler used in all major browsers.
This PR, fixes the following two errors when launching TWP or Freescape games:
I tried to figure out correct upper boundary for the new iteration limits, but would be good if somebody more knowledgeable could double check.