SCI: Fix King's Quest IV demo crash#6578
Merged
bluegr merged 1 commit intoscummvm:masterfrom Apr 28, 2025
Merged
Conversation
This patch is not compatible with the demo, and will cause it to crash with a "Send to invalid selector" error.
Member
|
Nice find! This patch is aimed at newer versions of KQ4, where the pic drawing logic was changed compared to earlier ones. The KQ4 demo features an earlier version of the pic drawing logic, so disabling that patch for the demo as a quick solution to the issue makes sense, and avoids us having to adapt the patch for the demo for no reason. Thanks again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was reported in https://forums.scummvm.org/viewtopic.php?t=17338 that the King's Quest IV demo (which can be found on the ScummVM demos page) crashes with the following messages:
Bisecting pointed to the "ride unicorn at night" patch. I suspect it has something to do with the "No selector vocabulary found" warning, but that's way beyond my knowledge of SCI. So this pull request simply disables the unicorn patch for the demo. To me that seems like the simplest, most elegant solution.
Note that I have not played the full game to verify that riding the unicorn at night still work as intended. I haven't played this game for many years (before ScummVM supported it), and from a quick glance at a walkthrough it seems I would have to play a substantial part of it to test this? So this should not be merged blindly. I just wanted to make sure that the bug doesn't get lost.
(I could have filed a bug report instead, but how often do I get to make pull requests for the SCI engine, and how cool is that? ;-)