TINYGL: Implement scissor test#6575
Merged
lephilousophe merged 7 commits intoscummvm:masterfrom Apr 28, 2025
Merged
Conversation
aquadran
approved these changes
Apr 27, 2025
This avoids keeping it enabled when switching tests.
Also setup a keymapper for the engine.
Clipping is not scissor.
When a test fails we still have to update the different parameters for the following points. Instead of returning, jump to the end of the function where the updates take place. This should also fix graphical issues with stencils.
lephilousophe
force-pushed
the
tgl-scissor
branch
from
e6ad246 to
52c96cd
Compare
Member
Author
|
Merging as it seems to work with Freescape. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup of #6412.
I implemented a test case in Playground3D (after enabling the keymapper for all tests) and, then, I managed to merge the already in-place clipping with the missing pieces to have a working scissor test.
Finally, a bug is fixed in the various pixel writing function where the update of the z, fog and color was not done.
@neuromancer you may want to test this with Freescape.