BUILD: Support both $_host-peldd and peldd for mingw builds#6574
Merged
lephilousophe merged 1 commit intoscummvm:masterfrom Apr 30, 2025
Merged
Conversation
toolchains/windows-9x currently only has a `peldd` binary, with no host prefix.
sev-
approved these changes
Apr 27, 2025
Member
|
Hum... I just looked at it and I don't know. 😄 I wonder if we should do the same on our Windows 9x toolchain or not. What's the result with your patch? Does it try to fetch opengl32 for example? |
Contributor
Author
You mean, what's the output being then fed to It's empty. So the PR just fixes the |
Member
|
OK! Then let's go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
windows-9xtoolchain, themake win32dist-mingw DESTDIR=win32dist-mingwstage would end with this output:i.e. the
pelddcode from previous PR #3196 wasn't called.Indeed, there is not such prefixed binary in the win9x toolchain:
Maybe something needs to be tweaked in the toolchain to have a prefixed version, but in the meantime I think also looking for a plain
pelddin our build scripts is quite reasonable.@lephilousophe: Any objection to this?