SCUMM: Add enhancement for missing message when entering ship's hold#6540
SCUMM: Add enhancement for missing message when entering ship's hold#6540bluegr merged 1 commit intoscummvm:masterfrom
Conversation
The first time Guybrush enters the ship's hold, there is a message where he remarks that the whole thing reeks of monkeys. But the way it's scripted, it's only shown if it has already been shown. We can enable the message by inverting the check.
|
That’s the kind of content restoration I love! I have a vague memory that I may have a version where it was enabled. Unfortunately I won’t have access to all my game editions this week. (It might just be me misremembering things, though.) |
I guess I should double-check that it can't be triggered in any other way. |
|
Judging by Nutcracker, at least in the English DOS CD version there are no references to that flag or that message outside of the entry script. So I see no possible way of triggering it in any other way. |
|
When asking around on Facebook, two people so far said they recognized the message but one admitted he might be suffering from the Mandela effect. Aric Wilmunder chimed in to say that his copy of the script (from March of 1992) had this bug. Facebook probably made mincemeat out of the formatting, but this is probably what he meant the script looked like: He agreed that it should have been |
|
Very interesting. So Aric sometimes looks in his Vault for such stuff, very cool. I may have a few things where it'd be quite useful (e.g. that "cut" script where Wally would cry for help when you start walking down the stairs in LeChuck's fortress in Monkey2) but I guess that's something for later 😄 Anyway, this change looks good to me. Don't worry about that vague memory of mine. Maybe it was in the patches of the Ultimate Talkie edition. I don't have access to all my games this week, but it's OK to me to check them myself after it's merged. |
|
Thanks for your work! Merging |
|
Hi, It appears that this caused a V1/V2 regression in daily builds. Commit 920513e should explain why and should provide a quick fix for this. @eriktorbjorn: Could you check whether this new change is fine to you? Thanks! |
|
@dwatteau Thanks for catching that! I remember being a bit worried about it at first, but thought I was safe. I didn't realize that earlier versions used I think this is the only use of o5_notEqualZero() in that script, so that we wouldn't really have to check which variable it used at all. But that seemed unnecessarily optimistic to me. So the current version looks good to me. |
|
OK, thanks! Coming back to this:
So, I've checked all the copies I have (including the ones I had in the Monkey Island Anthology from LimitedRunGames), and yeah, I was misremembering and having a Mandela effect too. None of my English or French copies displayed it, before this enhancement. The Ultimate Talkie edition didn't display it either. I guess I had a memory of having already seen this line, because of… the years I spent working on my own translation with Also, for posterity, here was Ron's answer about this game script: "[...] Not sure I'd call that a coding error. The lines were just cut. But what do I know. [...]" So yeah, maybe it was originally cut because it was a bit long, or something like that. |
The first time Guybrush enters the ship's hold, there is a message where he remarks that the whole thing reeks of monkeys. But the way it's scripted, it's only shown if it has already been shown. Here's how Nutcracker renders the script:
I assume that variables are automatically initialized to 0, because these are the only references I can find to
B.321. We can enable the message by inverting the check:In most versions, you should be able to reach the scene easily by using boot param 2222. Alternatively, you can teleport to room 9 and walk down into the hold.
I have tested this with:
Theoretically it could also apply to the "Ultimate Talkie" version, but we don't expose the enhancement settings to that version because of how many script changes it already includes.
But I could really use some help in testing it for the other versions and translations.