GRAPHICS: Add palette constructor for ownership of data#6525
Merged
sev- merged 1 commit intoscummvm:masterfrom Apr 27, 2025
Merged
GRAPHICS: Add palette constructor for ownership of data#6525sev- merged 1 commit intoscummvm:masterfrom
sev- merged 1 commit intoscummvm:masterfrom
Conversation
OMGPizzaGuy
force-pushed
the
palette-dispose
branch
from
69ec8cc to
74feebb
Compare
Member
|
Just noticed the PR. It Looks good to me. I'm going to merge it in now |
Member
|
Oh, it's still marked as a draft. Well, I have no objection to it being merged once you're ready for it |
Member
|
Yes, it is a step in the right direction. And we need to further fix/cleanup video code for using the Palette class. Merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One roadblock to expanded use of the palette class is my desire to not make extra memory copies the static palette data used in a number of classes. This new constructor with the use of DisposeAfterUse::NO and a const qualifier could be an answer to that problem.
Does this seem like a good path forward or are there alternate ideas?
Is this a silly concern and a small memory copy not a big enough deal to warrant a change?