ALL: Use C++ 11 range-based for loops#6508
Merged
sev- merged 58 commits intoscummvm:masterfrom Mar 27, 2025
Merged
Conversation
OMGPizzaGuy
reviewed
Mar 25, 2025
OMGPizzaGuy
reviewed
Mar 26, 2025
Member
|
I am merging this before it gets bitrot. The rest could be continued in-tree. Thank you, Filippos, for improving our codebase readability! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes most places in common code where range-based for loops are used to C++ 11 range-based for loops.
Therefore, loops like these:
have been changed to their C++ 11 equivalent:
I've used the following regexp to find and replace most cases:
and the replace macro:
I've then checked each change, and adapted the code inside the loops accordingly.
Only straightforward loops have been adapted, as mentioned above. The following loops have been left with the existing semantics:
erase()is calledinsert()is calledMost of the common code has been adapted, and a lot of the engine code has been adapted, too. Since this is a lengthy process, the rest of the engines will be adapted in a future PR.
Thoughts and opinions are welcome :)