X Tutup
Skip to content

DIRECTOR: Fixes for D5#6498

Merged
sev- merged 17 commits intoscummvm:masterfrom
moralrecordings:d5_features
Mar 25, 2025
Merged

DIRECTOR: Fixes for D5#6498
sev- merged 17 commits intoscummvm:masterfrom
moralrecordings:d5_features

Conversation

@moralrecordings
Copy link
Contributor

No description provided.

Similar to how you can get properties from nonexistent cast members,
Director will allow you to set them. This list was done by manually
checking in Director 4 which was a no-op instead of an exception.

Fixes Psych.
_mainHandle is a pointer to the projector archive, and is set once at
the start of execution. DirectorEngine is a better place for it rather
than the first Window, as other Windows might try and access it.

Fixes crash when changing the cursor in Microphone Fiend.
Handlers inside scoped script types (e.g. CastScript) should not be
discoverable via getHandler.

Fixes menu screen in Derrat Sorcerum.
Thanks to Tim Reimer for the tipoff.
Fixes director-tests/D4-unit/T_EVNT19.DIR
Replacing a cast member with a Picture will reset the _initialRect to
a generic one positioned at (0, 0).
Before we do that, untransform the registration offset
so that it remains relative to the image coordinates.

Fixes graphics in Dungeon Street.
Fixes inventory list dimensions in Derrat Sorcerum.
Fixes restoring save games in Derrat Sorcerum.
Fixes the dialogue entry box in Cosmology of Kyoto.

Fixes director-tests/D4-unit/T_LING03.DIR
34a60f7 introduced a problem with video
playback. For same-frame updates, the choice of redrawing widgets was
left to the channel code, and as the widgets returned by
DigitalVideoCastMember are generic bitmaps, there was no special case to
check if the video had updated.

Fixes intro movie in GADGET: Adventure, Travel and Adventure.
A few places in the code fetch the palette from the window manager. This
is not the source of truth; the WM might have a gamma-converted palette.

Fixes incorrect video colouring in the Mac version of Wrath of the Gods.
@sev-
Copy link
Member

sev- commented Mar 25, 2025

Thanks!

@sev- sev- merged commit f7e2a19 into scummvm:master Mar 25, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup