X Tutup
Skip to content
/ scummvm Public

CHAMBER: Fix cga_Blit to support HGA screen rendering#6493

Merged
sev- merged 1 commit intoscummvm:masterfrom
Nasir-Bilal:NAS0
Mar 21, 2025
Merged

CHAMBER: Fix cga_Blit to support HGA screen rendering#6493
sev- merged 1 commit intoscummvm:masterfrom
Nasir-Bilal:NAS0

Conversation

@Nasir-Bilal
Copy link
Contributor

@Nasir-Bilal Nasir-Bilal commented Mar 20, 2025

Modify C++ cga_BackBufferToRealFull()to support splash screen rendering in HGA mode:

  • Split CGA backbuffer into even/odd lines (pages) to match HGA memory layout.
  • Double CGA pixel width (4 pixels/byte → 8 pixels/byte) for HGA.
  • Center the image within the 720x348 HGA screen buffer.

@bluegr bluegr changed the title Fix cga_Blit to support HGA screen rendering CHAMBER: Fix cga_Blit to support HGA screen rendering Mar 20, 2025
@sev-
Copy link
Member

sev- commented Mar 20, 2025

Please follow our Commit Guidelines, the commit has to be fixed

sev-
sev- reviewed Mar 20, 2025
View reviewed changes
engines/chamber/chamber.cpp Outdated
_prioritycommand_2 = false;
_pxiData = NULL;
_videoMode = Common::kRenderCGA;
_videoMode = Common::kRenderHercG;
Copy link
Member

@sev- sev- Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shuld not be committed

@bluegr
Copy link
Member

bluegr commented Mar 20, 2025

Thanks!
Your commits need to conform to our commit guidelines. In particular, you need to prepend the engine prefix, which is "CHAMBER", in this case

@Nasir-Bilal
Copy link
Contributor Author

Nasir-Bilal commented Mar 20, 2025

Commit message updated as per guidelines.
_videoMode change reverted.
Please let me know if there’s anything else you’d like me to adjust. Thanks for the feedback

@sev-
Copy link
Member

sev- commented Mar 21, 2025

Thanks!

@sev- sev- merged commit 3acc19d into scummvm:master Mar 21, 2025
1 check passed
@sev- sev- added the GSoC Part of a Google Summer of Code project label Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sev- sev- sev- left review comments

Assignees

No one assigned

Labels

GSoC Part of a Google Summer of Code project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nasir-Bilal @sev- @bluegr
X Tutup