QDENGINE: LITTLE LONGNOSE: Fix missing walking animation and direction change#6482
Merged
sev- merged 2 commits intoscummvm:masterfrom Mar 18, 2025
Merged
QDENGINE: LITTLE LONGNOSE: Fix missing walking animation and direction change#6482sev- merged 2 commits intoscummvm:masterfrom
sev- merged 2 commits intoscummvm:masterfrom
Conversation
ormanbai123
force-pushed
the
karliknos-fix
branch
from
d0c34e4 to
66d95bc
Compare
sev-
requested changes
Mar 17, 2025
Member
sev-
left a comment
sev-
left a comment
There was a problem hiding this comment.
Suggested approach to minimize code changes.
ormanbai123
force-pushed
the
karliknos-fix
branch
from
66d95bc to
59132dd
Compare
ormanbai123
force-pushed
the
karliknos-fix
branch
from
59132dd to
821648b
Compare
ormanbai123
force-pushed
the
karliknos-fix
branch
from
821648b to
5e9ccfb
Compare
sev-
reviewed
Mar 18, 2025
| } | ||
|
|
||
| enum movement_mode_t { | ||
| MOVEMENT_MODE_NONE_EARLY, |
Member
There was a problem hiding this comment.
This is wrong, you shifted these enum values, and they get saved/loaded (see qdGameObjectMoving::save_data()). E.g. put it to the enum end.
also, please check static const char *movementList[]
ormanbai123
force-pushed
the
karliknos-fix
branch
from
5e9ccfb to
4f51faf
Compare
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix two issues present in the first minigame of the Little Longnose game:
The problems occurs because of the new movement modes which were absent in the engine when the game was made. The proposed solution replaces parts of code where they are used with the old engine's code.