DIRECTOR: Implement text line height#6480
Merged
sev- merged 2 commits intoscummvm:masterfrom Mar 18, 2025
Merged
Conversation
sev-
requested changes
Mar 12, 2025
| Datum castRef = g_lingo->pop(); | ||
|
|
||
| if (castRef.type != CASTREF) { | ||
| warning("Incorrect argument type for lineHeight"); |
Member
There was a problem hiding this comment.
No, you should use g_lingo->lingoError() here. Please check other places
Contributor
Author
There was a problem hiding this comment.
b_findEmpty might need be updated as well since it uses warning instead of g_lingo->lingoError()
| int TextCastMember::getLineHeight(int line) { | ||
| Graphics::MacWidget *target = getWidget(); | ||
| if (target) { | ||
| if (_textType == kTextTypeScrolling) { |
Member
There was a problem hiding this comment.
Yes, but making MacTextWindow a subclass of MacText, we will eliminate all of these conditions across the code
Contributor
Author
There was a problem hiding this comment.
I'll work on this as my next step.
rinevard
force-pushed
the
director-lineheight
branch
from
5fcb01d to
bcfb766
Compare
sev-
reviewed
Mar 12, 2025
rinevard
force-pushed
the
director-lineheight
branch
from
bcfb766 to
89d9c2c
Compare
sev-
reviewed
Mar 17, 2025
rinevard
force-pushed
the
director-lineheight
branch
from
89d9c2c to
3976649
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.