AGS: fix DynamicSprite.Flip() to use CreateTransparentBitmap#6472
Merged
bluegr merged 1 commit intoscummvm:masterfrom Mar 9, 2025
Merged
AGS: fix DynamicSprite.Flip() to use CreateTransparentBitmap#6472bluegr merged 1 commit intoscummvm:masterfrom
bluegr merged 1 commit intoscummvm:masterfrom
Conversation
Member
|
Nice catch, thanks for your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AGS: fix DynamicSprite.Flip() to use CreateTransparentBitmap
DynamicSprite.Flip() is using CreateBitmap instead of CreateTransparentBitmap meaning flipped sprites lose their transparency.
Looks like this creeped in during refactoring here (other methods are OK, just Flip):
3078b20#diff-4093ff4addff2a4251456a23d8da353c260c0dfd217919f3a0b0cfb31bae921bR126
Reference AGS code here:
https://github.com/adventuregamestudio/ags/blob/master/Engine/ac/dynamicsprite.cpp#L125
Test case are mirror reflections in The Crimson Diamond.