Merged
Conversation
The I (uppercase i) modifier is a Microsoft extension, and is not ISO compatible. MSVC supports the z modifier, which is ISO compatible, so use that everywhere inside the ImGui code. The relevant MSVC documentation can be found here: https://learn.microsoft.com/en-us/cpp/c-runtime-library/format-specification-syntax-printf-and-wprintf-functions?view=msvc-170
bluegr
force-pushed
the
director_warnings
branch
from
e910f30 to
794d6e6
Compare
Member
|
Thanks! |
einstein95
pushed a commit
to einstein95/scummvm
that referenced
this pull request
May 5, 2025
* DIRECTOR: Fix warning about usage of ABS() * DIRECTOR: Remove MSVC-specific argument size modifier prefix from imgui The I (uppercase i) modifier is a Microsoft extension, and is not ISO compatible. MSVC supports the z modifier, which is ISO compatible, so use that everywhere inside the ImGui code. The relevant MSVC documentation can be found here: https://learn.microsoft.com/en-us/cpp/c-runtime-library/format-specification-syntax-printf-and-wprintf-functions?view=msvc-170 * DIRECTOR: Fix assigning negative value to string end position
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix most of the warnings in the
directorengine, which are thrown by MSVC.Opening as a PR to get feedback on the changes, mostly the one about signed integers in file offsets, plus to check if everything builds OK.
@sev-, @moralrecordings, @rvanlaar, any feedback is welcome :)