TESTBED: Add test suite for image decoders by OMGPizzaGuy · Pull Request #6454 · scummvm/scummvm

OMGPizzaGuy · 2025-02-24T05:31:19Z

Adds test for image decoders using image created from the PM5544 test pattern using ImageMagick.
The pcx-24bpp seems to be rendered incorrectly with the wrong colors in this test. I'm not sure if there exist a specific configuration for PCX that would be correct or if a bug exists.

This test suite was built to test a few of the decoders altered in #6447

engines/testbed/image.cpp

bluegr · 2025-02-26T22:14:12Z

One odd thing I spotted: why are the test image files placed in a folder named "engine-data/testbed-audiocd-files/image"?

The "testbed-audiocd-files" folder is defined in testbed/sound.cpp. It would make more sense if these image files were placed in a more generic directory, e.g. "engine-data/testbed-files/image"

OMGPizzaGuy · 2025-02-26T22:48:24Z

One odd thing I spotted: why are the test image files placed in a folder named "engine-data/testbed-audiocd-files/image"?

The "testbed-audiocd-files" folder is defined in testbed/sound.cpp. It would make more sense if these image files were placed in a more generic directory, e.g. "engine-data/testbed-files/image"

I agree it is odd, but I believe it was never changed as it's used for the scummvm.ini [testbed] path and moving it would require devs to update their config files
The directory also contains an "imagealbum" directory used by MiscTests::testImageAlbum

engines/testbed/image.cpp

bluegr · 2025-02-27T13:53:04Z

Thanks! Merging

OMGPizzaGuy force-pushed the testbed-image branch from b311ba2 to 9011705 Compare February 24, 2025 23:24

bluegr reviewed Feb 25, 2025

View reviewed changes

engines/testbed/image.cpp Show resolved Hide resolved

mgerhardy reviewed Feb 25, 2025

View reviewed changes

engines/testbed/image.cpp Outdated Show resolved Hide resolved

OMGPizzaGuy force-pushed the testbed-image branch from 9011705 to 1d4105c Compare February 25, 2025 14:28

TESTBED: Add test suite for image decoders

2d5298e

OMGPizzaGuy force-pushed the testbed-image branch from 1d4105c to 2d5298e Compare February 27, 2025 00:44