AGS: Avoid stack frame size warning in AGS3::unload_game#6450
Merged
bluegr merged 1 commit intoscummvm:masterfrom Feb 23, 2025
Merged
AGS: Avoid stack frame size warning in AGS3::unload_game#6450bluegr merged 1 commit intoscummvm:masterfrom
bluegr merged 1 commit intoscummvm:masterfrom
Conversation
Instead of allocating the GameState and GameSetupStruct variables on stack and erase the heap version, deallocate the old ones and reallocate new ones.
Member
|
Before this change, I got the following warning: After the change, the warning is gone. So that part of it seems to work, at least. |
tag2015
approved these changes
Feb 23, 2025
Member
|
Thanks! Straightforward implementation, which fixes the issue at hand |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of allocating the GameState and GameSetupStruct variables on stack and erase the heap version, deallocate the old ones and reallocate new ones.