FREESCAPE: Implement skybox for opengl with shaders#6440
Merged
lephilousophe merged 1 commit intoscummvm:masterfrom Feb 16, 2025
Merged
FREESCAPE: Implement skybox for opengl with shaders#6440lephilousophe merged 1 commit intoscummvm:masterfrom
lephilousophe merged 1 commit intoscummvm:masterfrom
Conversation
neuromancer
reviewed
Feb 16, 2025
cmd05
force-pushed
the
skybox-opengl-shaders
branch
from
066c3a1 to
b28d201
Compare
cmd05
force-pushed
the
skybox-opengl-shaders
branch
from
b28d201 to
0be11ae
Compare
Contributor
Author
|
@lephilousophe Could you check now |
Contributor
|
From my side, this PR looks ready to merge. |
Member
|
Merging then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Freescape does not draw a skybox when using opengl with shaders to run Castle Master. I have defined
OpenGLShaderRenderer::drawSkyboxand used seperate cubemap shaders for the rendering. Only Castle Master will be affected by this.