Add support to select shader from the command line#6429
Merged
sev- merged 6 commits intoscummvm:masterfrom Feb 12, 2025
naatje80:master
Merged
Add support to select shader from the command line#6429sev- merged 6 commits intoscummvm:masterfrom naatje80:master
sev- merged 6 commits intoscummvm:masterfrom
naatje80:master
Conversation
mgerhardy
reviewed
Feb 11, 2025
base/commandLine.cpp
Outdated
| DO_OPTION('g', "gfx-mode") | ||
| END_OPTION | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
this change is not necessary
Contributor
Author
There was a problem hiding this comment.
Yes indeed, my apologies. I had to move the move the DO_LONG_OPTION functionality below the one that was created for the themepath (otherwise the default location of de shaders.dat file could not be found). I accidentally added an additional line feed. I will remove it.
Contributor
Author
There was a problem hiding this comment.
Should be fixed now.
bluegr
reviewed
Feb 12, 2025
sev-
reviewed
Feb 12, 2025
Typo: "of" should be "or". It also only excepts a single shader file (instead of files). Co-authored-by: Eugene Sandulenko <sev@scummvm.org>
Member
|
Thank you! I squashed your commits. Nice addition! |
Contributor
Author
|
Sure done, and thank you for merging these changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added feature: support to select shader from the command line
I was still missing an option to select a shader from the command line. I hope the provided addition could be merged. I don't think it will require more explanation. Otherwise please let me know.
With kind regards,
Nathan