GRAPHICS: Remove deprecated uses of primitives#6401
Merged
lephilousophe merged 14 commits intoscummvm:masterfrom Jan 24, 2025
Merged
GRAPHICS: Remove deprecated uses of primitives#6401lephilousophe merged 14 commits intoscummvm:masterfrom
lephilousophe merged 14 commits intoscummvm:masterfrom
Conversation
lephilousophe
force-pushed
the
macgui-primitives
branch
2 times, most recently
from
afe03b3 to
c9817d4
Compare
lephilousophe
changed the title
Member
Author
|
I just migrated a bunch of obsolete primitives. BTW, I think we miss an optimization in drawLine to call drawHLine or drawVLine for a range of points. |
lephilousophe
force-pushed
the
macgui-primitives
branch
2 times, most recently
from
976cee6 to
cac81af
Compare
Contributor
|
Looked through the changes that were director related. I don't have comments about them.
I do wonder if we should continue with the PR or revert it. I'll leave that up to others. |
ccawley2011
reviewed
Jan 23, 2025
This allows to draw polygon and ellipses directly on the surfaces.
This makes the code comply with the latest API changes. The drawing calls now need to be optimized for the complex shapes.
lephilousophe
force-pushed
the
macgui-primitives
branch
from
cac81af to
d78ebd1
Compare
Member
Author
|
Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the deprecation warnings introduced by PR #6374.
I also removed casts which were noxious because the types got changed with this PR.(already committed by digitall)The Primitives objects are preallocated to avoid allocation for every draw operation.
We could easily optimize the code by providing a drawHLine primitive but that's pending a clarification of the behaviour when thickness is greater than 1 and the invert flag is set.
In this case, the current code overlaps the writes and some patterns may appear.