GOB: improve magicstones detection#6400
Merged
bluegr merged 1 commit intoscummvm:masterfrom Jan 10, 2025
Merged
Conversation
Member
|
Thanks! |
Member
lephilousophe
left a comment
lephilousophe
left a comment
There was a problem hiding this comment.
I have a couple of comments on this PR.
| MetaEngineDetection::GAME_NOT_IMPLEMENTED, // A la poursuite du dragon de feu (Engine: DEV7 version 1.2.0.0) | ||
| AD_ENTRY2s("ed4.stk", "98721a7cfdc5a358d7ac56b7c6d3ba3d", 541882, | ||
| "ed4cd.itk", "0627a91d9a6f4772c33747ce752024c2", 606993908), | ||
| "ed4_cd.itk", "0627a91d9a6f4772c33747ce752024c2", 606993908), |
Member
There was a problem hiding this comment.
This changes the filename.
@Strangerke could you check?
Contributor
Author
There was a problem hiding this comment.
I own an physical copy of the french version and there is it ed4_cd.itk and those hashes are identical.
|
|
||
| "magicstones", | ||
| MetaEngineDetection::GAME_NOT_IMPLEMENTED, // Le pays des Pierres Magiques (Engine: DEV7 version 1.2.0.0) | ||
| MetaEngineDetection::GAME_NOT_IMPLEMENTED, // A la poursuite du dragon de feu (Engine: DEV7 version 1.2.0.0) |
Member
There was a problem hiding this comment.
Why this change?
A la poursuite du dragon de feu is only the subtitle of the game.
Contributor
Author
There was a problem hiding this comment.
This what my physical copy is called, I added the subtitle as an reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.