GRAPHICS: Remove masks from ManagedSurface::transBlitFrom#6377
Merged
bluegr merged 4 commits intoscummvm:masterfrom Jan 8, 2025
Merged
GRAPHICS: Remove masks from ManagedSurface::transBlitFrom#6377bluegr merged 4 commits intoscummvm:masterfrom
bluegr merged 4 commits intoscummvm:masterfrom
Conversation
Contributor
|
0af2f19 just a reminder for my future me... (gif animations, twine) |
elasota
approved these changes
Jan 8, 2025
Contributor
elasota
left a comment
elasota
left a comment
There was a problem hiding this comment.
Seems fine to me for the mTropolis part
Member
|
Thanks for your work! Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new set of functions has been added in its place that wraps around the shared mask code. It should be sufficient to cover the one place that uses it, but I'm not able to test it. Some modifications have been made to the TwinE engine as well, which used the
maskOnlyparameter without actually having a mask, which I think is just to disable the colour key, but those changes are untested as well.