GRAPHICS: Remove overrideColor from ManagedSurface::transBlitFrom#6375
Merged
bluegr merged 2 commits intoscummvm:masterfrom Dec 30, 2024
Merged
GRAPHICS: Remove overrideColor from ManagedSurface::transBlitFrom#6375bluegr merged 2 commits intoscummvm:masterfrom
bluegr merged 2 commits intoscummvm:masterfrom
Conversation
Member
|
This looks like a useful feature... why remove it from common code? |
Member
Author
|
Member
|
Thanks for your work and explanation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Sherlock engine was the only user of this feature, and it was only implemented for paletted surfaces. Removing it allows the ManagedSurface blitting code to be simplified a bit.