AUDIO: MT32: Force MT32 rebuild after configure is run#6370
Merged
sev- merged 1 commit intoscummvm:masterfrom Dec 29, 2024
Merged
AUDIO: MT32: Force MT32 rebuild after configure is run#6370sev- merged 1 commit intoscummvm:masterfrom
sev- merged 1 commit intoscummvm:masterfrom
Conversation
When configuration flags are changed (ASan enabling for example), force rebuild the MT32 objects. They were not rebuild because not depending on config.h
Member
|
I was thinking about this exact problem. E.g. if a feature is enabled in-between builds, you may get no rebuild. I am not sure about the hack you wrote, though :D |
Member
Author
|
Normally, everything is rebuild properly if we disable features/components because config.mk is loaded at every make invocation: this will always calculate the correct set of translation units to link (and, by dependency, check the state of the object files). Every object file of the codebase depends on config.h (through scummsys.h directly or indirectly) . |
Member
|
Okay, let's mere and see how it behaves |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When configuration flags are changed (ASan enabling for example), force rebuild the MT32 objects.
They were not rebuild because not depending on config.h
I prefer to submit this as a PR because it's a bit hackish and if someone has a better idea, I take it.