Palette color distance definitions#6362
Merged
bluegr merged 2 commits intoscummvm:masterfrom Dec 26, 2024
Merged
Conversation
Member
|
Do you have a use case for these methods? Can you show the difference when using each method visually (e.g. by using a reference image)? |
Member
Author
I do not have examples. This is clarification of the existing methods - "redmean" is the existing default, and "naive" only used in the Scumm engine. I could try to add something to testbed to show and image reduced to RGB 332 palette with each method. |
Contributor
|
I used this function by chance in something I wrote yesterday, so I appreciate the clarification of what |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes define the methods currently used for palette color matching. I have no immediate plans to support additional methods.
For reference: https://en.wikipedia.org/wiki/Color_difference