JANITORIAL: Add FIXMEs for typos in hadesch engine#6343
Merged
bluegr merged 3 commits intoscummvm:masterfrom Dec 26, 2024
Merged
JANITORIAL: Add FIXMEs for typos in hadesch engine#6343bluegr merged 3 commits intoscummvm:masterfrom
bluegr merged 3 commits intoscummvm:masterfrom
Conversation
bluegr
reviewed
Dec 25, 2024
engines/hadesch/rooms/ferry.cpp
Outdated
| { "V9260tA0", { "V9260nA0", _hs("Charon can't have any monsters at the head of the boat") } }, | ||
| { "V9260tB0", { "V9260nB0", _hs("No animals at the head of the boat") } }, // 5 | ||
| { "V9260tC0", { "V9260nC0", _hs("Charon wont sit next to two-headed beings") } }, | ||
| { "V9260tC0", { "V9260nC0", _hs("Charon won't sit next to two-headed beings") } }, |
Member
There was a problem hiding this comment.
This should be a FIXME comment instead, as it modifies data
Contributor
Author
There was a problem hiding this comment.
Yes, i thought so as well, but look at the following lines, they all have won't with an apostrophe, so i figured it would be safe to change this single line?
Please advise
Contributor
There was a problem hiding this comment.
No, please, refrain from changing game data, no matter the patterns you see.
Contributor
Author
There was a problem hiding this comment.
reverted to a fixme
thank you
Contributor
Author
There was a problem hiding this comment.
what did i break now? 😞
sorry
Member
There was a problem hiding this comment.
@raziel- you didn't break anything. Builds have been broken by another commit
raziel-
changed the title
Member
|
Thanks, squashing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.