GRAPHICS: Apply aspect ratio correction to 16 color VGA 640x350 video…#6311
Merged
bluegr merged 2 commits intoscummvm:masterfrom Dec 17, 2024
Merged
Conversation
Member
Author
|
I noticed that there are a lot of implementations of |
Member
|
Do you have any screenshots with aspect ratio correction disabled for comparison? |
NMIError
reviewed
Dec 14, 2024
|
|
||
| // In case we enable aspect ratio correction we force a 4/3 ratio. | ||
| // But just for 320x200, 640x400 and Hercules games, since other | ||
| // But just for 320x200, 640x400, 640x350 (16 color VGA) and Hercules games, since other |
Contributor
There was a problem hiding this comment.
Nitpick: 640 x 350 is an EGA resolution. Dark Seed uses a trick to use the VGA palette in this mode, but that is not normally available.
Member
Author
There was a problem hiding this comment.
Good point I'll change the text to clarify that
Member
Author
Yeah it looks like this when uncorrected.
|
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Darkseed uses an unusual video mode 640x350 16 colors. This should be aspect ratio corrected.
This PR applies the Aspect Ratio Correction setting to this video mode.