X Tutup
Skip to content
/ scummvm Public

CONFIGURE: Don't use the Gold linker on i386/ppc (unless using --enable-gold) #6285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluegr merged 1 commit into from
Jan 30, 2025
Merged

CONFIGURE: Don't use the Gold linker on i386/ppc (unless using --enable-gold) #6285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ _pandoc=no
_curl=yes
_lld=no
_mold=no
_gold=yes
_gold=auto
# Default vkeybd/eventrec options
_vkeybd=no
_eventrec=no
Expand Down Expand Up @@ -2507,6 +2507,19 @@ else
define_in_config_if_yes yes 'NO_CXX11_ALIGNAS'
fi

# The Gold linker had known issues on at least i386 and ppc32, in some cases.
# Since this linker is not very maintained anymore, and since alternatives exist,
# avoid using it on non-mainstream archs, unless --enable-gold was explicitly given.
if test "$_gold" = auto; then
case $_host_cpu in
aarch64 | x86_64 | amd64)
;;
*)
_gold=no
;;
esac
fi

#
# Determine extra build flags for debug and/or release builds
#
Expand Down Expand Up @@ -2542,7 +2555,7 @@ if test "$_debug_build" != no; then
append_var LDFLAGS "-fuse-ld=mold"
append_var LDFLAGS "-Wl,--gdb-index"
echo_n -- " + Mold"
elif test "$_gold" = yes && cc_check_no_clean $debug_mode -gsplit-dwarf -fuse-ld=gold -Wl,--gdb-index; then
elif test "$_gold" != no && cc_check_no_clean $debug_mode -gsplit-dwarf -fuse-ld=gold -Wl,--gdb-index; then
append_var LDFLAGS "-fuse-ld=gold"
append_var LDFLAGS "-Wl,--gdb-index"
echo_n -- " + Gold"
Expand Down
Loading
X Tutup