[backend/GLFW] Added bounds check#5621
Merged
raysan5 merged 2 commits intoraysan5:masterfrom Mar 4, 2026
Merged
Conversation
CrackedPixel
changed the title
CrackedPixel
force-pushed
the
fix-glfw-crash-controllerconnected
branch
from
26f578d to
099d8db
Compare
JeffM2501
reviewed
Mar 4, 2026
CrackedPixel
force-pushed
the
fix-glfw-crash-controllerconnected
branch
from
099d8db to
406ad3a
Compare
Owner
|
@CrackedPixel Nice! Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue where my apps were crashing if you connect a gamepad during runtime. Only on linux.
I found this with the same issue, and it showed a commit where it "started": #4954
in that issue, this commit was noted as the culprit.. and if you set the
MAX_GAMEPAD_NAME_LENGTHback to 64 it masks the issueIf you add a debug log to this function, you will see the
jidis beyond the array index. im not sure how glfw decides the IDs but i believe its some platform specific code they have that makes it not happen on windows? or maybe with the alignment its just been lucky.This must be why it has different behavior on different versions of raylib or different runs (RLGL has null context, fps cap changes, etc), because its overwriting random memory with the overflow