X Tutup
Skip to content

chore: change name of API functional test to api_func_v4#2147

Merged
nejch merged 1 commit intomainfrom
jlvillal/api_func_v4
Jul 19, 2022
Merged

chore: change name of API functional test to api_func_v4#2147
nejch merged 1 commit intomainfrom
jlvillal/api_func_v4

Conversation

@JohnVillalovos
Copy link
Member

The CLI test is cli_func_v4 and using api_func_v4 matches with
that naming convention.

@JohnVillalovos JohnVillalovos marked this pull request as draft July 15, 2022 01:45
@JohnVillalovos JohnVillalovos marked this pull request as ready for review July 15, 2022 01:57
@JohnVillalovos JohnVillalovos requested a review from nejch July 15, 2022 01:57
@JohnVillalovos
Copy link
Member Author

@nejch Not sure what you think about this. I'm fine to drop it but just thought I liked the naming consistency.

The CLI test is `cli_func_v4` and using `api_func_v4` matches with
that naming convention.
@nejch
Copy link
Member

nejch commented Jul 19, 2022

Thanks @JohnVillalovos - yes, this one has annoyed me for a while as well. :) We'll just need to change required checks again.

@nejch nejch merged commit ed110bd into main Jul 19, 2022
@nejch nejch deleted the jlvillal/api_func_v4 branch July 19, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup