X Tutup
Skip to content

gh-97731: Specify the full path to the docs for make docclean#98982

Merged
brettcannon merged 4 commits intopython:mainfrom
brettcannon:make-docclean-97731
Nov 2, 2022
Merged

gh-97731: Specify the full path to the docs for make docclean#98982
brettcannon merged 4 commits intopython:mainfrom
brettcannon:make-docclean-97731

Conversation

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Nov 1, 2022 •
edited by bedevere-bot
Loading

This is to have make clean not error out on cross-builds.

@brettcannon
Specify the full path to the docs for make docclean
66f8189 
This is to have `make clean` not error out on cross-builds.
@brettcannon brettcannon self-assigned this Nov 1, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 1, 2022
Closed
@brettcannon brettcannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 1, 2022
@bedevere-bot
Copy link

bedevere-bot commented Nov 1, 2022

🤖 New build scheduled with the buildbot fleet by @brettcannon for commit 66f8189 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 1, 2022
@brettcannon
Copy link
Member Author

brettcannon commented Nov 1, 2022

Leaving this as a draft (and incomplete w/ no news entry) until I can verify that cross-builds like for WASI pass cleanly with this fix.

If it's still a failure than I will add a - prefix to simply allow the command to fail.

@brettcannon
Copy link
Member Author

brettcannon commented Nov 1, 2022

Trying to find out why such a small subset of buildbots got put on to this PR.

@brettcannon brettcannon added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section build The build process and cross-build labels Nov 1, 2022
@bedevere-bot
Copy link

bedevere-bot commented Nov 1, 2022

🤖 New build scheduled with the buildbot fleet by @brettcannon for commit 66f8189 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 1, 2022
@brettcannon brettcannon requested a review from zware November 2, 2022 18:46
@brettcannon brettcannon marked this pull request as ready for review November 2, 2022 18:46
@brettcannon brettcannon added needs backport to 3.11 only security fixes needs backport to 3.10 only security fixes labels Nov 2, 2022
@brettcannon brettcannon merged commit 22bab74 into python:main Nov 2, 2022
@brettcannon brettcannon deleted the make-docclean-97731 branch November 2, 2022 19:34
@miss-islington
Copy link
Contributor

miss-islington commented Nov 2, 2022

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Nov 2, 2022

GH-99024 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 2, 2022
@bedevere-bot
Copy link

bedevere-bot commented Nov 2, 2022

GH-99025 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 2, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2022
@brettcannon @miss-islington
pythongh-97731: Specify the full path to the docs for make docclean (…
8de7b7e 
…pythonGH-98982)

Specify the full path to the docs for `make docclean`
This is to have `make clean` not error out on cross-builds.
(cherry picked from commit 22bab74)

Co-authored-by: Brett Cannon <brett@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2022
@brettcannon @miss-islington
pythongh-97731: Specify the full path to the docs for make docclean (…
adbdac4 
…pythonGH-98982)

Specify the full path to the docs for `make docclean`
This is to have `make clean` not error out on cross-builds.
(cherry picked from commit 22bab74)

Co-authored-by: Brett Cannon <brett@python.org>
miss-islington added a commit that referenced this pull request Nov 2, 2022
@miss-islington @brettcannon
gh-97731: Specify the full path to the docs for make docclean (GH-9…
dc4bf6b 
…8982)

Specify the full path to the docs for `make docclean`
This is to have `make clean` not error out on cross-builds.
(cherry picked from commit 22bab74)

Co-authored-by: Brett Cannon <brett@python.org>
brettcannon pushed a commit that referenced this pull request Nov 2, 2022
@miss-islington
[3.10] gh-97731: Specify the full path to the docs for make docclean (
0774f83 
GH-98982) (#99025)

Specify the full path to the docs for `make docclean`
This is to have `make clean` not error out on cross-builds.
(cherry picked from commit 22bab74)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware zware approved these changes

Assignees

@brettcannon brettcannon

Labels

build The build process and cross-build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brettcannon @bedevere-bot @miss-islington @zware
X Tutup