gh-98832: Change wording in docstring of pathlib.Path.iterdir#98833
gh-98832: Change wording in docstring of pathlib.Path.iterdir#98833miss-islington merged 5 commits intopython:mainfrom
pathlib.Path.iterdir#98833Conversation
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
LGTM (but I won't merge just yet, in case Brett has some feedback)
iritkatriel
changed the title
pathlib.Path.iterdirpathlib.Path.iterdir
brettcannon
left a comment
brettcannon
left a comment
There was a problem hiding this comment.
Stdlib practice is a single sentence summarizing what something does, a newline, and then any relevant details. We should probably go ahead and fix that now.
Otherwise LGTM!
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Brett Cannon <brett@python.org>
|
Thanks! Applied. To make our bot happy: I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @brettcannon, @AlexWaygood: please review the changes made to this pull request. |
|
Status check is done, and it's a success ✅. |
|
Sorry, I can't merge this PR. Reason: |
|
Status check is done, and it's a success ✅. |
6 participants
Found while working on #98829
pathlib.Path.iterdirdocstring #98832Automerge-Triggered-By: GH:AlexWaygood