gh-90535: Warn of deprecation of intervals other than 1 with when='MIDNIGHT'#98099
gh-90535: Warn of deprecation of intervals other than 1 with when='MIDNIGHT'#98099vsajip wants to merge 2 commits intopython:mainfrom
when='MIDNIGHT'#98099Conversation
brettcannon
changed the title
brettcannon
changed the title
when=='MIDNIGHT'
brettcannon
changed the title
when=='MIDNIGHT'when='MIDNIGHT'
| self.fn, encoding="utf-8", when='MIDNIGHT', interval=2, backupCount=0, | ||
| utc=True) | ||
| rh.close() | ||
| if w: |
There was a problem hiding this comment.
Do you want the test to pass if no warning is raised? If not then in the above I would force deprecations on as exceptions via warnings.simplefilter("error").
There was a problem hiding this comment.
Good point. Thanks for the review, Brett.
There was a problem hiding this comment.
Why not use assertWarns()?
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
I do not think that this change is needed. What if you want to roll over at 4:00 every second night? What are the alternatives?
| import queue | ||
| import threading | ||
| import copy | ||
| import warnings |
There was a problem hiding this comment.
It is better to defer the warnings module import until it is needed (which never happen in normal case).
| self.fn, encoding="utf-8", when='MIDNIGHT', interval=2, backupCount=0, | ||
| utc=True) | ||
| rh.close() | ||
| if w: |
There was a problem hiding this comment.
Why not use assertWarns()?
|
#116220 is an alternate solution, which fixes support of intervals>1 instead of deprecating it for when='MIDNIGHT' and when='Wx'. |
|
I guess it can be closed now. |
5 participants
Uh oh!
There was an error while loading. Please reload this page.