gh-97725: Fix default file in Task.print_stack#97726
Closed
megabug wants to merge 2 commits intopython:mainfrom
Closed
gh-97725: Fix default file in Task.print_stack#97726megabug wants to merge 2 commits intopython:mainfrom
Task.print_stack#97726megabug wants to merge 2 commits intopython:mainfrom
Conversation
`Task.print_stack` is described by documentation as having a default output file of `sys.stderr`. However, instead the default `None` is passed all the way to `print` statements, leading to an actual default of `sys.stdout`. Fix by setting the file to `sys.stderr` when the default is used.
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
All commit authors signed the Contributor License Agreement. |
kumaraditya303
requested changes
Oct 2, 2022
Contributor
kumaraditya303
left a comment
kumaraditya303
left a comment
There was a problem hiding this comment.
Please add a regression test for this.
kumaraditya303
added
type-bug
Member
|
But do we want to fix the code to match the docs? In cases like this, where the docs and the code have always disagreed (or for many releases), we tend to prefer to fix the docs to match the code, since "fixing" the code may actually break apps that were expecting the observed behavior. Also, |
Contributor
|
Superseded by #101652 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asyncio.Task.print_stackis described by documentation as having a default output file ofsys.stderr. However, the defaultNoneis passed all the way toprintstatements, leading to an actual default ofsys.stdout.Fix by setting the file to
sys.stderrwhen the default is used.asyncio.Task.print_stackdoesn't usesys.stderrby default #97725