gh-92550: Fix pathlib.Path.rglob() for empty pattern#92604
Merged
serhiy-storchaka merged 2 commits intopython:mainfrom May 11, 2022
Merged
gh-92550: Fix pathlib.Path.rglob() for empty pattern#92604serhiy-storchaka merged 2 commits intopython:mainfrom
serhiy-storchaka merged 2 commits intopython:mainfrom
Conversation
serhiy-storchaka
added
type-bug
barneygale
reviewed
May 10, 2022
| "dirA", "dirA/linkC", "dirB", "dirB/linkD", "dirC", | ||
| "dirC/dirD", "dirE", "linkB", | ||
| ]) | ||
| _check(p.rglob(""), ["", "dirA", "dirB", "dirC", "dirE", "dirC/dirD"]) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Member
Author
There was a problem hiding this comment.
No, it should include the original directory for compatibility with the old code of Path.rglob() and with glob.glob(recursive=True).
rhettinger
approved these changes
May 10, 2022
brettcannon
approved these changes
May 10, 2022
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-92657 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 11, 2022
miss-islington
added a commit
that referenced
this pull request
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92550