gh-91629 Use conf.d configs and fish_add_path to set the PATH when installing for the Fish shell.#91630
Merged
ned-deily merged 5 commits intopython:mainfrom Apr 21, 2024
drewcassidy:better-fish-install
Merged
gh-91629 Use conf.d configs and fish_add_path to set the PATH when installing for the Fish shell.#91630ned-deily merged 5 commits intopython:mainfrom drewcassidy:better-fish-install
ned-deily merged 5 commits intopython:mainfrom
drewcassidy:better-fish-install
Conversation
• Use conf.d instead of modifying config.fish • Use fish-add-path instead of modifying $PATH directly to avoid duplicates
|
All commit authors signed the Contributor License Agreement. |
erlend-aasland
approved these changes
May 17, 2022
Contributor
|
@ned-deily, leaving this to you :) |
Contributor
Author
|
Hey uh, this PR is nearing its second birthday, any chance of it getting reviewed? |
Misc/NEWS.d/next/macOS/2022-04-17-01-07-42.gh-issue-91629.YBGAAt.rst
Outdated
Show resolved
Hide resolved
erlend-aasland
approved these changes
Apr 15, 2024
Contributor
erlend-aasland
left a comment
erlend-aasland
left a comment
There was a problem hiding this comment.
Still looks good to me. I'll land this next week, to give Ned a chance to review it :) cc. @ned-deily
ned-deily
approved these changes
Apr 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #91629 by writing path-setting configs to conf.d and using fish_add_path