gh-68114: Fix handling for removed PyArg_ParseTuple formatters#8204
gh-68114: Fix handling for removed PyArg_ParseTuple formatters#8204encukou merged 11 commits intopython:mainfrom
Conversation
|
Please merge with master and resolve conflicts with bpo-23927. |
|
@llllllllll, please resolve the merge conflicts and address the code review. Thank you! |
MaxwellDupre
left a comment
MaxwellDupre
left a comment
There was a problem hiding this comment.
Test_capi produces:
Ran 40 tests in 7.553s
OK
Looks ok.
iritkatriel
left a comment
iritkatriel
left a comment
There was a problem hiding this comment.
This has merge conflicts now.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
- Don't use removed trivial helper raiseTestError - Decref kwargs if it's created - Export the test so that it is run
The original patch didn't call va_arg, resulting in corruption when 'w*' was used.
|
After a few years of unresolved comments I think I can take over the PR. |
encukou
force-pushed
the
remove-old-formatters
branch
from
5f5e116 to
2aee71c
Compare
encukou
changed the title
11 participants
re-opening this as a github pull request @serhiy-storchaka
The only difference from the old patch is that I used
blurbto write the news entry.https://bugs.python.org/issue23926