gh-74044: inspect.signature for wrappers around decorated bound methods by anton-ryzhov · Pull Request #736 · python/cpython

anton-ryzhov · 2017-03-20T09:25:28Z

If we wrap function with bound method, which is also a wrapper around function, inspect.signature will not do skip_bound_arg.
It will use inspect.unwrap and pass by bound method from outer function to inner one.

Reproducer:

import functools, inspect


def decorator(func):
    @functools.wraps(func)
    def inner(*args):
        return func(*args)
    return inner


class Foo(object):
    @decorator
    def bar(self, testarg):
        pass


f = Foo()
baz = decorator(f.bar)
assert inspect.signature(baz) == inspect.signature(f.bar)

Issue: inspect.signature includes bound argument for wrappers around decorated bound methods #74044

mention-bot · 2017-03-20T09:25:33Z

@anton-ryzhov, thanks for your PR! By analyzing the history of the files in this pull request, we identified @1st1, @larryhastings and @zestyping to be potential reviewers.

anton-ryzhov · 2017-03-20T09:53:22Z

@the-knights-who-say-ni Got "Contributor Form Received"

Lib/inspect.py

1st1 · 2017-03-21T16:17:07Z

@anton-ryzhov Good catch. The code looks OK, just add a comment explaining why your change works in all cases.

…und decorated bound methods

anton-ryzhov · 2017-03-23T06:31:02Z

@1st1 In case you haven't received notification about last push, I'm notifying about this by the comment.

vstinner · 2019-01-10T16:01:15Z

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

csabella · 2019-04-10T00:01:58Z

@1st1, I believe your requested changes have been made and this is ready for another review. Thanks!

csabella · 2019-11-16T02:05:26Z

Closing and reopening to trigger tests.

MaxwellDupre

Tested as per given test case, result pass.
Module test passed test_inspect.
Noted make failed to build nis module.
Looks ok to me.

Lib/inspect.py

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

bedevere-bot · 2022-11-09T14:26:04Z

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

iritkatriel · 2022-11-09T14:41:59Z

@anton-ryzhov This needs a news entry.

anton-ryzhov · 2022-11-09T19:49:50Z

Done

Misc/NEWS.d/next/Library/2022-11-09-20-48-42.gh-issue-74044.zBj26K.rst

miss-islington · 2022-11-10T12:32:05Z

Thanks @anton-ryzhov for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

… methods (pythonGH-736) (cherry picked from commit dbf2faf) Co-authored-by: Anton Ryzhov <anton@ryzhov.me>

bedevere-bot · 2022-11-10T12:32:22Z

GH-99328 is a backport of this pull request to the 3.11 branch.

… methods (pythonGH-736) (cherry picked from commit dbf2faf) Co-authored-by: Anton Ryzhov <anton@ryzhov.me>

bedevere-bot · 2022-11-10T12:32:29Z

GH-99329 is a backport of this pull request to the 3.10 branch.

…ds (GH-736) (cherry picked from commit dbf2faf) Co-authored-by: Anton Ryzhov <anton@ryzhov.me>

… methods (pythonGH-736)

This comment was marked as outdated.

Sign in to view

the-knights-who-say-ni added the CLA not signed label Mar 20, 2017

serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.5 labels Mar 20, 2017

serhiy-storchaka requested a review from 1st1 March 20, 2017 09:37

Mariatta removed the CLA not signed label Mar 20, 2017

the-knights-who-say-ni added the CLA signed label Mar 20, 2017

1st1 reviewed Mar 21, 2017

View reviewed changes

Lib/inspect.py Outdated Show resolved Hide resolved

bpo-29858: inspect.signature includes bound argument for wrappers aro…

9737829

…und decorated bound methods

anton-ryzhov force-pushed the fix-issue-29858 branch from 1b7ac75 to 9737829 Compare March 22, 2017 06:18

brettcannon removed the needs backport to 3.5 label Aug 11, 2017

brettcannon added the awaiting review label Feb 21, 2018

serhiy-storchaka added the needs backport to 3.7 label Dec 10, 2018

vstinner removed the needs backport to 3.6 label Jan 10, 2019

csabella requested a review from 1st1 April 9, 2019 23:59

csabella requested review from 1st1 and removed request for 1st1 November 16, 2019 02:03

csabella closed this Nov 16, 2019

csabella reopened this Nov 16, 2019

ned-deily removed the needs backport to 3.7 label Jun 28, 2020

MaxwellDupre approved these changes Feb 15, 2022

View reviewed changes

bedevere-bot removed the awaiting review label Feb 15, 2022

AlexWaygood changed the title ~~bpo-29858: inspect.signature for wrappers around decorated bound methods~~ gh-74044: inspect.signature for wrappers around decorated bound methods Nov 9, 2022

iritkatriel reviewed Nov 9, 2022

View reviewed changes

Lib/inspect.py Outdated Show resolved Hide resolved

Update Lib/inspect.py

1c0afba

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>

iritkatriel approved these changes Nov 9, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Nov 9, 2022

iritkatriel added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes and removed stale Stale PR or inactive for long period of time. labels Nov 9, 2022

Add news note

ea0a2a5

anton-ryzhov force-pushed the fix-issue-29858 branch from 0b1f485 to ea0a2a5 Compare November 9, 2022 20:14

iritkatriel reviewed Nov 10, 2022

View reviewed changes

Misc/NEWS.d/next/Library/2022-11-09-20-48-42.gh-issue-74044.zBj26K.rst Outdated Show resolved Hide resolved

iritkatriel added 2 commits November 10, 2022 11:51

Apply suggestions from code review

b822f40

Merge branch 'main' into fix-issue-29858

53eb3fb

iritkatriel merged commit dbf2faf into python:main Nov 10, 2022

bedevere-bot removed the awaiting merge label Nov 10, 2022

anton-ryzhov mannequin mentioned this pull request Nov 9, 2022

inspect.signature includes bound argument for wrappers around decorated bound methods #74044

Closed

bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 10, 2022

bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 10, 2022

miss-islington added a commit that referenced this pull request Nov 10, 2022

gh-74044: inspect.signature for wrappers around decorated bound metho…

1de088c

…ds (GH-736) (cherry picked from commit dbf2faf) Co-authored-by: Anton Ryzhov <anton@ryzhov.me>

miss-islington added a commit that referenced this pull request Nov 10, 2022

gh-74044: inspect.signature for wrappers around decorated bound metho…

e6f066a

…ds (GH-736) (cherry picked from commit dbf2faf) Co-authored-by: Anton Ryzhov <anton@ryzhov.me>

ethanfurman pushed a commit to ethanfurman/cpython that referenced this pull request Nov 12, 2022

pythongh-74044: inspect.signature for wrappers around decorated bound…

3b826ba

… methods (pythonGH-736)

Uh oh!

Conversation

anton-ryzhov commented Mar 20, 2017 • edited by AlexWaygood Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

mention-bot commented Mar 20, 2017

Uh oh!

anton-ryzhov commented Mar 20, 2017

Uh oh!

Uh oh!

1st1 commented Mar 21, 2017

Uh oh!

anton-ryzhov commented Mar 23, 2017

Uh oh!

vstinner commented Jan 10, 2019

Uh oh!

csabella commented Apr 10, 2019

Uh oh!

csabella commented Nov 16, 2019

Uh oh!

MaxwellDupre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Nov 9, 2022

Uh oh!

iritkatriel commented Nov 9, 2022

Uh oh!

anton-ryzhov commented Nov 9, 2022

Uh oh!

Uh oh!

miss-islington commented Nov 10, 2022

Uh oh!

bedevere-bot commented Nov 10, 2022

Uh oh!

bedevere-bot commented Nov 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

anton-ryzhov commented Mar 20, 2017 •

edited by AlexWaygood

Loading