gh-91498: socket: Add TCP_CONNECTION_INFO on macOS#69256
Merged
JelleZijlstra merged 2 commits intopython:mainfrom Apr 27, 2022
Merged
gh-91498: socket: Add TCP_CONNECTION_INFO on macOS#69256JelleZijlstra merged 2 commits intopython:mainfrom
JelleZijlstra merged 2 commits intopython:mainfrom
Conversation
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
This should also be added to Doc/library/socket.rst, similar to the existing notes under https://docs.python.org/3.10/library/socket.html#socket.SOMAXCONN.
Member
There was a problem hiding this comment.
Suggested change
| Adding ``TCP_CONNECTION_INFO`` macOs' option for the socketmodule | |
| Add the ``TCP_CONNECTION_INFO`` option (available on macOS) to :mod:`socket`. |
Member
|
Also, this should have an associated issue. Your NEWS entry refers to https://bugs.python.org/issue69256 which doesn't exist. We're in the process of moving to GitHub right now; once that's done (in a few hours I believe) you should make an associated GitHub issue. |
devnexen
force-pushed
the
tcp_connection_info_macos
branch
from
036540c to
07e935f
Compare
devnexen
changed the title
methane
changed the title
devnexen
force-pushed
the
tcp_connection_info_macos
branch
from
07e935f to
ae87fea
Compare
JelleZijlstra
approved these changes
Apr 27, 2022
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Compiled on my Mac and it's indeed present
>>> socket.TCP_CONNECTION_INFO
262
JelleZijlstra
added a commit
to python/typeshed
that referenced
this pull request
Apr 30, 2022
AlexWaygood
pushed a commit
to python/typeshed
that referenced
this pull request
Apr 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #91498