[3.10] bpo-42369: Fix thread safety of zipfile._SharedFile.tell (GH-26974)#32009
Merged
miss-islington merged 1 commit intopython:3.10from Mar 20, 2022
Merged
Conversation
) The `_SharedFile` tracks its own virtual position into the file as `self._pos` and updates it after reading or seeking. `tell()` should return this position instead of calling into the underlying file object, since if multiple `_SharedFile` instances are being used concurrently on the same file, another one may have moved the real file position. Additionally, calling into the underlying `tell` may expose thread safety issues in the underlying file object because it was called without taking the lock. (cherry picked from commit e730ae7) Co-authored-by: Kevin Mehall <km@kevinmehall.net>
serhiy-storchaka
approved these changes
Mar 20, 2022
Contributor
Author
|
@kevinmehall and @serhiy-storchaka: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_SharedFiletracks its own virtual position into the file asself._posand updates it after reading or seeking.tell()shouldreturn this position instead of calling into the underlying file object,
since if multiple
_SharedFileinstances are being used concurrently onthe same file, another one may have moved the real file position.
Additionally, calling into the underlying
tellmay expose threadsafety issues in the underlying file object because it was called
without taking the lock.
(cherry picked from commit e730ae7)
Co-authored-by: Kevin Mehall km@kevinmehall.net
https://bugs.python.org/issue42369