X Tutup
Skip to content

bpo-2604: Make DocTestCase reset globs in teardown#31932

Merged
JelleZijlstra merged 3 commits intopython:mainfrom
DanielNoord:fix-issue-2604
Mar 22, 2022
Merged

bpo-2604: Make DocTestCase reset globs in teardown#31932
JelleZijlstra merged 3 commits intopython:mainfrom
DanielNoord:fix-issue-2604

Conversation

@DanielNoord
Copy link
Contributor

@DanielNoord DanielNoord commented Mar 16, 2022 •
edited
Loading

Targets bpo-2604 and bpo-9736.

Combination of both patches as suggested by Irit Katriel on bpo-2604.

I didn't include a news entry as I didn't think it was necessary for test changes. Let me know if I should add one!

https://bugs.python.org/issue2604

@DanielNoord
bpo-2604: Make DocTestCase reset globs in teardown
1b19fa0 
Co-authored-by: Piet Delport
Co-authored-by: Hugo Lopes Tavares
@JelleZijlstra
Copy link
Member

JelleZijlstra commented Mar 16, 2022

Thanks! I think this does need a news entry because doctest is a public API and this fixes a user-visible bug.

@DanielNoord
Copy link
Contributor Author

DanielNoord commented Mar 16, 2022

@JelleZijlstra Added 😄

Not sure if that also means that this needs to be back ported, but I'll leave that decision up to you.

@JelleZijlstra JelleZijlstra self-requested a review March 17, 2022 06:22
@DanielNoord @JelleZijlstra
Update Misc/NEWS.d/next/Library/2022-03-16-18-25-19.bpo-2604.jeopdL.rst
6bf8f09 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstra JelleZijlstra self-assigned this Mar 19, 2022
@JelleZijlstra JelleZijlstra merged commit 7ba7eae into python:main Mar 22, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Mar 22, 2022

Thanks @DanielNoord for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Mar 22, 2022

Sorry @DanielNoord and @JelleZijlstra, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7ba7eae50803b11766421cb8aae1780058a57e2b 3.10

@bedevere-bot
Copy link

bedevere-bot commented Mar 22, 2022

GH-32057 is a backport of this pull request to the 3.9 branch.

@JelleZijlstra JelleZijlstra added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels Mar 22, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Mar 22, 2022

Thanks @DanielNoord for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

bedevere-bot commented Mar 22, 2022

GH-32058 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Mar 22, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 22, 2022
@DanielNoord @miss-islington
bpo-2604: Make doctest.DocTestCase reset globs in teardown (pythonGH-…
0d4c7f5 
…31932)

Co-authored-by: Piet Delport
Co-authored-by: Hugo Lopes Tavares
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 7ba7eae)

Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 22, 2022
@DanielNoord @miss-islington
bpo-2604: Make doctest.DocTestCase reset globs in teardown (pythonGH-…
986cce8 
…31932)

Co-authored-by: Piet Delport
Co-authored-by: Hugo Lopes Tavares
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 7ba7eae)

Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Mar 22, 2022
@miss-islington @DanielNoord
bpo-2604: Make doctest.DocTestCase reset globs in teardown (GH-31932)
3c60190 
Co-authored-by: Piet Delport
Co-authored-by: Hugo Lopes Tavares
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 7ba7eae)

Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Mar 22, 2022
@miss-islington @DanielNoord
bpo-2604: Make doctest.DocTestCase reset globs in teardown (GH-31932)
f163ad2 
Co-authored-by: Piet Delport
Co-authored-by: Hugo Lopes Tavares
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 7ba7eae)

Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
@DanielNoord DanielNoord deleted the fix-issue-2604 branch March 23, 2022 07:29
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @DanielNoord @hello-adam
bpo-2604: Make doctest.DocTestCase reset globs in teardown (pythonGH-…
e797897 
…31932)

Co-authored-by: Piet Delport
Co-authored-by: Hugo Lopes Tavares
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 7ba7eae)

Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
@serhiy-storchaka serhiy-storchaka mentioned this pull request Feb 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DanielNoord @JelleZijlstra @miss-islington @bedevere-bot @the-knights-who-say-ni
X Tutup