gh-91102: Use Argument Clinic for EncodingMap #31725
Merged
JelleZijlstra merged 7 commits intopython:mainfrom Apr 18, 2022
Merged
gh-91102: Use Argument Clinic for EncodingMap #31725JelleZijlstra merged 7 commits intopython:mainfrom
JelleZijlstra merged 7 commits intopython:mainfrom
Conversation
arhadthedev
changed the title
arhadthedev
changed the title
Member
Author
|
The change is internal so no NEWS entry is required. |
arhadthedev
changed the title
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thanks, but could you add a NEWS entry? The class is actually accessible from Python:
>>> _codecs.charmap_build("\0abc")
<EncodingMap object at 0x1052ff790>
Member
Author
|
Addressed. |
JelleZijlstra
approved these changes
Apr 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A part of #91102.